-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ignore SAML issues in GH API #17662
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me! Just wants a wee syntax tweak (use dig
) and a comment.
Co-authored-by: Mike McQuaid <[email protected]>
Just to clarify:
|
I'm not the convinced the GraphQL part of |
I get a list of errors telling me to allow my Homebrew token access to the SAML orgs. And the command fails. EDIT: found it
|
I think we can fix this by either changing the GraphQL query or scoping this better to be a @MikeMcQuaid just to check what the GraphQL query is intended to do here. Right now it only checks PRs created from non-forks (i.e. only covers maintainers). The REST API query also seems to only be invoked if the user has >= 100 PRs across all of GitHub. |
This was not intended, whoops. Should be checking the base repository owner of the PR instead.
The, perhaps incorrect, intent here was that if they have <100 open PRs: we can instead iterate over them rather than having to hit the REST API. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?This should allow people with SAML login for organisations that are not related to Homebrew (like me) to use commands that need the GH API.